It's probably not a particularly egregious one, all things considered, but adding extra fluff and redundancy to code is usually only a bad thing, it's more cruft to have to wade through when trying to maintain the code in the future. using (SomeDisposableResource foo = new SomeDisposableResource())
{
foo.Frob();
}SomeDisposableResource foo = null;
try
{
foo = new SomeDisposableResource();
foo.Frob();
}
finally
{
if (foo != null)
{
((IDisposable)foo).Dispose();
}
}The reason that feels like a hackjob to me is that every derived class' reset() has to manually call the protected implementation in base class, and you might conceivably also forget to do it.
private void btnAttackPh_Click(object sender, EventArgs e)
{
DisableAttackButtons();
int playerDMG = CalculateAttackDamage(PlayerStrength);
EnemyAttacked(playerDMG);
//tmrCombat.Tick
int enemyDMG = CalculateAttackDamage(EnemyStrength);
PlayerAttacked(enemyDMG);
if (PlayerCurrentHealth != 0)
EnableAttackButtons();
}Sanders Nathan 1778 N. Deer Run Detroit MI45634B
Wilson Dylan 12345 N. Malibu Beach Blvd Irvine CA97894I
Stewart Connor 13456 E. Wilshire Blvd Santa Monica CA97845IWhich language?
private void btnAttackPh_Click(object sender, EventArgs e)
{
DisableAttackButtons();
btnTutorial.Enabled = false;
int playerDMG = CalculateAttackDamage(PlayerStrength);
EnemyAttacked(playerDMG);
tmrCombat.Start();
}
private void tmrCombat_Tick(object sender, EventArgs e)
{
if (CurrentEnemyHealth != 0)
{
int enemyDMG = CalculateAttackDamage(EnemyStrength);
PlayerAttacked(enemyDMG);
}
if (PlayerCurrentHealth != 0 && CheckLevel == false)
{
EnableAttackButtons();
btnTutorial.Enabled = true;
}
tmrCombat.Stop();
}int pos = strlen(my_string) - 1;
while (isspace(my_string[pos]) && pos > 0) {
my_string[pos--] = '\0';
}You should do whatever is simplest. In my opinion, it's much simpler to copy the whole line from the file into a string, and then edit the string afterward.
tag to post code, it looks much nicer. Like so:
[code]public class Uppgift2 {
public static void main(String[] args)
{
String emil = "ABCDEFGHIJKLMNOPQRSTUVXYZ";
for (int i = 0; i < 25; i = i + 1)
{
System.out.print(emil.charAt(i));
}
}
}int main()
{
int int_array[8] = {5, 1, 3, 6, 9, 8, -1, 4};
min_and_max(int_array,8);
char char_array[8] = {'C', 'T', 'K', 'A', 'V', 'B', 'D', 'E'};
min_and_max(char_array,8);
return 0;
}template <class L>
void min_and_max (L my_array, int size)
{
int count;
int max, min;
min = my_array[0];
for (count = 1; count < size; count++)
{
if (my_array[count] < min)
min = my_array[count];
}
cout << "Output:" << endl;
cout << "Min: " << min;
max = my_array[0];
for (count = 1; count < size; count++)
{
if (my_array[count] > max)
max = my_array[count];
}
cout << ", Max: " << max << endl;
}What i'm getting
Output:
Min: -1, Max: 9
Output:
Min: 65, Max: 86
What I should be getting
Output:
Min: -1, Max: 9
Output:
Min: A, Max: Vint max, min;L max, min;matrix[ i ][ j ] = (rand( ) % 100 <= percent)Having to read code from paper and figure out what it does / find bugs is also good.
if(!matrix[ i ][ j ])int getRawData(FILE* fp, struct nameRecord records[], int currSize)#include <stdio.h>
#include <string.h>
#include <ctype.h>
#include <stdlib.h>
struct nameRecord {
char name[31];
int year;
int frequency;
};
void allCaps(char[]);
int getRawData(FILE*, struct nameRecord[], int);
void setYearTotals(struct nameRecord, int, int);
void setNameYearTotals(char, struct nameRecord, int, int);
void getPerHundredThousand(int, int, double);
void printData(double);
void graphPerHundredThousand(double);
int main(void)
{
int currSizem = 0;
int currSizef = 0;
struct nameRecord *records;
FILE* fp = NULL;
FILE* fp2 = NULL;
char name[31];
printf("Please enter your name: ");
scanf("%30[^\n]", name);
printf("your name is %s\n", name);
//opening both male and female name files and reading them in order to get the total number of records in the array
fp = fopen("malebabynames.csv", "r");
if (fp != NULL) {
printf("file opened\n");
while(3 == fscanf(fp, "%[^,],%d,%d", records[currSizem].name, &records[currSizem].year, &records[currSizem].frequency)) {
currSizem++;
}
} else {
printf("file failed to open\n");
}
if(currSizem > 0) {
records = malloc(currSizem * sizeof(struct nameRecord));
}
fp2 = fopen("femalebabynames.csv", "r");
if (fp != NULL) {
printf("file opened\n");
while(3 == fscanf(fp2, "%[^,],%d,%d", records[currSizef].name, &records[currSizef].year, &records[currSizef].frequency)) {
currSizef++;
}
} else {
printf("file failed to open\n");
}
if(currSizef > 0) {
records = malloc(currSizef * sizeof(struct nameRecord));
}
return 0;
}
//function that automatically capitalizes the users inputted name
void allCaps(char s[]) {
while(*s != '\0') {
*s = toupper((unsigned char) *s);
s++;
}
}
//function that reads and places the read files into the struct arrays
int getRawData(FILE* fp, struct nameRecord records[], int currSize) {
int i;
for(i = 0; i < currSize; i++) {
fscanf(fp, "%[^,],%d,%d", records[i].name, &records[i].year, &records[i].frequency);
}
return 0;
}public:
SchedulerThread();
~SchedulerThread();
void shutdown();
void schedule(const std::function<void()>& fun, unsigned millis);
void schedulePeriodic(const std::function<void()>& fun, unsigned millis);
protected:
void run();
void waitForWork();
bool doWork();class Book(Product):
def __init__(self, pub, aut, isbn, pid, name, price, stock):
Product.__init__(self, pid, name, price, stock)
self.pub = pub
self.aut = aut
self.isbn = isbn$(".wtf").hover(function() {
$("i", this).addClass("hidden");
$("span", this).removeClass("hidden");
}, function() {
$("span", this).addClass("hidden");
$("i", this).removeClass("hidden");
});<ul>
<li>
<a class="wtf" href="#">
<i class="fa fa-chevron-up"></i>
<span class="hidden">top</span>
</a>
</li>
</ul>Button 1 = Change Array[1] to "On"
Button 2 = Change Array[2] to "On"add ( Button(clickFunction(1)) );add ( Button( function():void { clickFunction(1) } ) );Where are you loading the file? Above the ".wtf" element or below it? If the script is loaded before the elements, it won't find the ".wtf" element, so nothing will happen.