Do you think Yamcha asks Puar to transform into this every night? I mean, you'd think no one would stoop that low, but then again, this is Yamcha we're talking about.
I don't think Yamcha's like that. He's the kind of guy who goes to sleep thinking that maybe tomorrow's the day, maybe he'll finally get his chance to shine, maybe he'll finally get to be the hero, maybe his hard work will finally pay off. He denies the reality around him, suppresses the emotions he should feel, and believes what he wants to believe instead of what he needs to. One or two arcs later it'll become to much for him to bear, and it'll all come out in once, one horrible midlife crisis.
Same as it ever was.