My favorite controllers are all over the place but they are all unique to the consoles that they play on. My favorites are as follows.
Nintendo Gamecube
Nintendo 64
Wii Remote and Nunchuk
Playstation Dual Shock 2, 4, and Dual Sense
Super Nintendo Pad
NES Controller
Sega Dreamcast
Switch Joy Cons
Each of these controllers are unique in their identity to the games and console they were on. Most of the games in the libraries take advantage of the controller features and add so much depth to the experience that I can't imagine those games played on other controllers not designed for them. I love everything about these controllers from the feel, to them wacky, to experimental, and to levels of immersion they bring to the table.
The only reason I don't like the Xbox controller is because I find them the most boring of the controllers. Its generic and not unique. Glad people enjoy them but I just feel like a Xbox Controller is so boring.
Now is every controller I like perfect? Hell no. They all have some issues but only in small instances, but I don't mind it when there is so much going for them I put up with them and barely notice them when I am playing. These controllers help me define what makes their hardware and games unique to play on their respective pads. They define the consoles experience.