Putin is laughing right now.
"America made this treaty to stop communism, but now that I'm working with the Russians, you should pay for protection"
That good will died when Trump put in the Muslim ban.
It just means that if we ever get a good president again, he will get super good will as the world will try to show what being a decent president can do for you while demonstrating now what an asshole president will do for you at the current time. Its the way its got to go. I don't think America will lose the goodwill permanently unless this becomes a multi president thing. I mean America is sure to lose middle eastern goodwill most likely permanently but I think most of the West will take a long term look at it. Its not like we have treated the middle east any better during multiple past presidencies although compared to how Trump treats it the way we treated them in the past seems nice.
EDIT: The West overall, not just the USA has taken the wrong approach with both Africa and the Middle east the entire 20th century with how it was divided and even further back with colonialism so America doesn't really stand alone there. Outside slavery, America did not really play the biggest part in devastating Africa in the first place, that was all Europe. America didn't start involving itself with Africa after post American Civil War until after post WWII
America's biggest screwups in the 19th century were really in our Southern Hemisphere and that stretched late into the 20th century. And we were not so much imperial there like Europe was in Africa. We just propped up a lot of bad governments and did some regime change but did not colonize them. And saying just doesn't mean I am downplaying it, we were responsible for some bad things happening all over South America which caused a LOT of suffering.