And I feel now more justifed as a character than just 'oh she's a superfan in the show how meta'
A beloved relative of mine, referring to a wildly successful fan proxy character in another Moffat show <cough>, refers to Osgood as FailMolly.
She's waiting to watch the Series 9 disc, rather than watching the show live, and I've conveyed my excitement about the first episode of this two-parter. I think I'll tell her just how exciting I found the conclusion.
It isn't so much the fangirl thing, with Osgood. The key scene that establishes her character in the show is that moment in Day of the Doctor when they both bond. My interpretation (for what little it's worth) is as follows. Fair warning: I do have a track record of overthinking these matters.
At the climax of the Zygon subplot in Day of the Doctor, like everybody else in the room the Osgoods didn't know which of them was human and which was Zygon, but they did know which one of them had the inhaler beforehand. Thus each deduced their own identity in the same instant. They each exchange a conspiratorial smile. That's the key character-determining moment.
For some reason, perhaps the emotional effect of seeing three versions of their hero acting as one, perhaps the quality of their Zygon-mediated personal rapport, perhaps the sense that peace is actually possible, they rapidly forge a strong bond.
Osgood had a problematic relationship with her blood sister, but when one of her is killed by Missy the remaining Osgood puts on the gravestone only "My sister." The peace with which both of Osgood identify has linked them irrevocably.
Inevitably Bonnie joins the Osgood sisterhood in the end. Because, awwwww! Doctor Who: Friendship is Magic.