Knightfall holds up surprisingly well, imo. It helps that it's a strong story on its own, as well as being a light deconstruction of 90's superhero trends.
I like Knightfall a lot, it's one of the few big 90s event stories that still holds up to this day. I'm curious to see how the omnibus contents differ from the big paperbacks they put out a few years back.